Skip to content

Commit

Permalink
Get CI working
Browse files Browse the repository at this point in the history
  • Loading branch information
cspray committed Jul 8, 2022
1 parent 9cfe505 commit e42e27a
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 13 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ use Cspray\Phinal\AllowInheritance;
final class ProperlyMarkedFinal {}

#[AllowInheritance('Explain why you would need to inherit this.')]
class YouCanInherite
class YouCanInheritThis {}
```

Bad! :-1:
Expand Down
4 changes: 1 addition & 3 deletions phpcs.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
<arg name="colors"/>

<!-- Paths to check -->
<file>Plugin.php</file>
<file>tests</file>

<file>src</file>

<!-- inherit rules from: -->
<rule ref="PSR12"/>
Expand Down
11 changes: 6 additions & 5 deletions src/AllowInheritance.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@
use Attribute;

#[Attribute(Attribute::TARGET_CLASS)]
final class AllowInheritance {

public function __construct(public string $why) {}

}
final class AllowInheritance
{
public function __construct(public string $why)
{
}
}
10 changes: 6 additions & 4 deletions src/ClassNotFinal.php
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
<?php declare(strict_types=1);
<?php

declare(strict_types=1);

namespace Cspray\Phinal;

use Psalm\Issue\PluginIssue;

final class ClassNotFinal extends PluginIssue {

}
final class ClassNotFinal extends PluginIssue
{
}
1 change: 1 addition & 0 deletions tests/_support/AcceptanceTester.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
* @method static pause()
*
* @SuppressWarnings(PHPMD)
* @psalm-suppress UndefinedTrait
*/
class AcceptanceTester extends \Codeception\Actor
{
Expand Down

0 comments on commit e42e27a

Please sign in to comment.