Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for error in aggregate functions #470

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

droberts-ctrlo
Copy link
Contributor

This branch is taken straight from v2.5.5 tag

This branch is taken straight from v2.5.5 tag
@droberts-ctrlo
Copy link
Contributor Author

I didn't know which origin branch to do the PR for - obvs change it if you need to.

@abeverley abeverley merged commit 0bb76d4 into ctrlo:dev Oct 17, 2024
5 of 6 checks passed
@abeverley
Copy link
Contributor

Thanks Dave. Just to note that you could also have done this if you wanted:

$data->{$_->id} = $agg->get_field_value($_)->for_table
    foreach grep {$_->aggregate}, @{$records->columns_render};

@droberts-ctrlo droberts-ctrlo deleted the aggregate-fix branch October 17, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants