Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Toggle for NewModule Form and skipCRDs Support in Backend #616

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kom-senapati
Copy link
Contributor

@kom-senapati kom-senapati commented Oct 7, 2024

closes #602

πŸ“‘ Description

  • Added support for the skipCRDs option in the backend reconciliation logic.
  • Added a toggle switch for the skipCRDs option in the frontend NewModule form.

βœ… Checks

  • I have tested my code (provide screenshots or screen recordings of a working solution)
  • I have performed a self-review of my code

Screenshots

image

@kom-senapati kom-senapati requested a review from a team as a code owner October 7, 2024 13:37
@kom-senapati
Copy link
Contributor Author

@quest-bot loot #602

@quest-bot quest-bot bot added the βš”οΈ Quest Tracks quest-bot quests label Oct 7, 2024
Copy link

quest-bot bot commented Oct 7, 2024

Quest PR submitted! image Quest PR submitted!

@kom-senapati, you are attempting to solve the issue and loot this Quest. Will you be successful?


Questions? Check out the docs.

Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skip crds values from the UI is not properly passed when creating a module and is never applied.

Also, since you are changing the CRD, run make manifests to generate manifests in cyclops-ctrl/config/crd/bases, and make sure the value is properly mapped in the kubernetes cluster

cyclops-ui/src/components/pages/NewModule/NewModule.tsx Outdated Show resolved Hide resolved
@kom-senapati
Copy link
Contributor Author

@petar-cvit Can you tell me the changes required in the backend

@kom-senapati
Copy link
Contributor Author

$ make manifests
make: *** No rule to make target 'manifests'.  Stop.

It's giving this output when running inside the cyclops-ctrl/config/crd/bases directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
βš”οΈ Quest Tracks quest-bot quests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add skipCRDs option to Module definition
2 participants