[ENH] add functionality to send later scheduled sending #1091
Conversation
amaninyumu1
force-pushed
the
Cypht-delay-send-later-scheduled-sending
branch
from
7aaffb2
to
0c58a6a
Compare
|
Will this work with JMAP as well? |
amaninyumu1
force-pushed
the
Cypht-delay-send-later-scheduled-sending
branch
from
0c58a6a
to
0aef136
Compare
|
Yes, anything we add for IMAP, we should check JMAP support as well. Overall, it is built on top of IMAP, so it should work but please check if the new Scheduled folder is OK for JMAP. Overall, the code is good but I have one concern - it only sends out while you are actively using Cypht and it seems to warn of unsent/scheduled messages each time you leave a page (onbeforeunload). That would be annoying for the end user. I believe this comment #576 (comment) proposes using sendAt support from jmap servers or scheduled send - if it is supported, we use it, if not, we fallback to a more annoying option. At any rate, it should be configurable. This could be fully-supported in the Cypht-Tiki integration where there could be a Tiki command run periodically in the scheduler that checks and sends scheduled messages. |
|
@kroky I added a commit to fix issue concerning onbeforeunload event and also add the option to change schedule time or send the message immediately. Can you check please. |
josaphatim
force-pushed
the
Cypht-delay-send-later-scheduled-sending
branch
2 times, most recently
from
36599a8
to
2da4ff4
Compare
|
@amaninyumu1 If you need help with JMAP, please reach out to @Shadow243 as he set up a JMAP server for testing. |
amaninyumu1
force-pushed
the
Cypht-delay-send-later-scheduled-sending
branch
2 times, most recently
from
45374ae
to
bdf9d5d
Compare
Baraka24
force-pushed
the
Cypht-delay-send-later-scheduled-sending
branch
5 times, most recently
from
cf0574d
to
af1c185
Compare
|
@amaninyumu1 "This branch has conflicts that must be resolved" |
amaninyumu1
force-pushed
the
Cypht-delay-send-later-scheduled-sending
branch
2 times, most recently
from
141f8d9
to
16293f5
Compare
amaninyumu1
force-pushed
the
Cypht-delay-send-later-scheduled-sending
branch
from
16293f5
to
41c9b95
Compare
amaninyumu1
force-pushed
the
Cypht-delay-send-later-scheduled-sending
branch
from
41c9b95
to
3fb7802
Compare
|
@amaninyumu1 This branch has conflicts that must be resolved |
amaninyumu1
force-pushed
the
Cypht-delay-send-later-scheduled-sending
branch
from
3fb7802
to
e725bcc
Compare
|
Hello @marclaporte , @kroky I resolved the conflicts. please review |
modules/smtp/modules.php
Outdated
| }} | ||
|
|
||
| if (!hm_exists('reschedule_message_sending')) { | ||
| function reschedule_message_sending($handler, $imap, $msg_id, $folder, $new_date, $server_id) { |
There was a problem hiding this comment.
Use modules.php only for handle or output modules. Move the functions to its own functions.php file to keep the existing structure in other modules (e.g. imap and core).
amaninyumu1
force-pushed
the
Cypht-delay-send-later-scheduled-sending
branch
from
5f0695c
to
740bf92
Compare
I added more details in your inbox, I hope it becomes clear! |
amaninyumu1
force-pushed
the
Cypht-delay-send-later-scheduled-sending
branch
3 times, most recently
from
4e9a10e
to
e84485a
Compare
|
Hello @jacob-js I make changes please review |
amaninyumu1
force-pushed
the
Cypht-delay-send-later-scheduled-sending
branch
from
e84485a
to
14a305b
Compare
|
Hello @jacob-js . I just made some changes. try, please review |
|
Great, please resolve the threads for which you believe you have met the change criteria. |
amaninyumu1
force-pushed
the
Cypht-delay-send-later-scheduled-sending
branch
2 times, most recently
from
e1970a2
to
e614a8e
Compare
amaninyumu1
force-pushed
the
Cypht-delay-send-later-scheduled-sending
branch
2 times, most recently
from
5a01da8
to
2f6c6a8
Compare
amaninyumu1
force-pushed
the
Cypht-delay-send-later-scheduled-sending
branch
3 times, most recently
from
4783879
to
9461c1e
Compare
amaninyumu1
force-pushed
the
Cypht-delay-send-later-scheduled-sending
branch
from
9461c1e
to
302cd2c
Compare
issue
issue