JAVA-3166: Enhanced exception handling of C* driver executeAsync() #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-antoniak
force-pushed
the
JAVA-3166
branch
from
585472d
to
5eef0a9
Compare
| @@ -41,7 +40,16 @@ class AsyncExecutor[T, R](asyncAction: T => CompletionStage[R], maxConcurrentTas | |||
| val executionTimestamp = System.nanoTime() | |||
|
|
|||
| def tryFuture(): Future[R] = { | |||
| val value = asyncAction(task) | |||
There was a problem hiding this comment.
maybe something more Scala'ish - Try { ... } map { ... } ?
lukasz-antoniak
force-pushed
the
JAVA-3166
branch
from
5eef0a9
to
c73bef1
Compare
jacek-lewandowski
approved these changes
Aug 26, 2024
tarzanek
pushed a commit
to tarzanek/spark-scylladb-connector
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling of exceptions that may be thrown by
CqlSession#executeAsync(). Otherwise semaphore inAsyncExecutoris not released and processing of further tasks blocked.Fixes: JAVA-3166