Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Untagged union #37

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Conversation

MierenManz
Copy link
Collaborator

This pr add's Union aka untagged union.
These still use a discriminant but the union does not consume the discriminant.
Useful for validating types or for types that may need the discriminant info to make a js value out of it

Copy link
Member

@load1n9 load1n9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@eliassjogreen eliassjogreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Great work!

@eliassjogreen eliassjogreen changed the title Untagged union feat: Untagged union Jul 12, 2024
@eliassjogreen eliassjogreen merged commit 8a52ae9 into denosaurs:main Jul 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants