Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trace fix improvements #2386

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Trace fix improvements #2386

wants to merge 19 commits into from

Commits on Oct 9, 2024

  1. move reference spectra transforms into dedicated function. 

    Also use different psfs to convolve the spectrum
    @segasai
    segasai committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    31710ad View commit details
    Browse the repository at this point in the history

  2. additional updates

    @segasai
    segasai committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    b35478e View commit details
    Browse the repository at this point in the history

  3. move code into separate function to be reused

    @segasai
    segasai committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    61c241d View commit details
    Browse the repository at this point in the history

  4. log the internal offsets

    @segasai
    segasai committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    5a1b754 View commit details
    Browse the repository at this point in the history

  5. subtract continuum when doing internal calirbation

    @segasai
    segasai committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    7f500c5 View commit details
    Browse the repository at this point in the history

  6. make the continuum subtraction in self-calibration optional

    @segasai
    segasai committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d5c29cf View commit details
    Browse the repository at this point in the history

  7. use actual variance not variance times flux

    @segasai
    segasai committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    389f1e1 View commit details
    Browse the repository at this point in the history

  8. update window of medianing

    @segasai
    segasai committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    9587395 View commit details
    Browse the repository at this point in the history

  9. deal with the fact that different functions oversample differently 

    therefore the filtering size needs to depend on that
    @segasai
    segasai committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    764d413 View commit details
    Browse the repository at this point in the history

  10. make sure arcs are still processed with continuum as before

    @segasai
    segasai committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ee20370 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. fix variable name

    @segasai
    segasai committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    be4d316 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. switch to f-formatting in a couple of instances

    @segasai
    segasai committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a4050eb View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. use correct weights for central wavelength

    @segasai
    segasai committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    2f6e80a View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. update variable names 

    get rid of useless warning
    @segasai
    segasai committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    0f03f5c View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. add functions docstrings

    @segasai
    segasai committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    aa1cf83 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. get rid of comment on oversampling 

    fix a few typos in comments
    @segasai
    segasai committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    b3c5ba3 View commit details
    Browse the repository at this point in the history

  2. few more typos

    @segasai
    segasai committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    b08cb4e View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. make the selection more readable

    @segasai
    segasai committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    ece6b59 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trace_fix_improvements' of github.com:desihub/desispec … 

    …into trace_fix_improvements
    @segasai
    segasai committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    083ca2b View commit details
    Browse the repository at this point in the history