Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Creating Slice.py #15

Merged
merged 7 commits into from
Feb 27, 2024
Merged

Creating Slice.py #15

merged 7 commits into from
Feb 27, 2024

Conversation

SDelgado-21
Copy link
Collaborator

first translation into python

@SDelgado-21 SDelgado-21 changed the title translating Slice.py Creating Slice.py Feb 25, 2024
@SDelgado-21 SDelgado-21 marked this pull request as ready for review February 25, 2024 07:16
@nedtwigg
Copy link
Member

This looks excellent! Only one change, let's use inline typing instead of the "comment-based" thing. Looks like ChatGPT uses comment-typing unless we explicitly ask it to put the types inline.

@nedtwigg
Copy link
Member

@SDelgado-21 SDelgado-21 marked this pull request as draft February 27, 2024 03:21
@SDelgado-21 SDelgado-21 marked this pull request as ready for review February 27, 2024 03:52
@nedtwigg nedtwigg merged commit d4bac8b into diffplug:main Feb 27, 2024
2 checks passed
@nedtwigg
Copy link
Member

Great work! Next up for you is SourceFile, the next part of

I would

  • create an issue for it
  • link to the kotlin code that you're going to port, and any tests that are relevant to it
  • then start writing python code

If you need help just let me know.

@nedtwigg nedtwigg mentioned this pull request Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants