Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEAB-5762: Pagination for entry versions #2023

Draft
wants to merge 17 commits into
base: develop
Choose a base branch
from
Draft

Conversation

hyunnaye
Copy link
Contributor

@hyunnaye hyunnaye commented Sep 23, 2024

Description
This PR implements pagination for versions in both the My workflows and the public entry page.

Pagination for workflow with 600+ versions
image

My workflows page (Note the hidden versions are visible)
image

Public page (Hidden versions are not visible)
image

Review Instructions
Go to https://qa.dockstore.org/workflows/github.com/broadinstitute/gatk/cnv_somatic_pair_workflow:4.2.0.0?tab=versions
and verify pagination works

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5762

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@hyunnaye hyunnaye self-assigned this Sep 23, 2024
@hyunnaye hyunnaye changed the title Feature/seab 5762 SEAB-5762: Pagination for entry versions Oct 4, 2024
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
56.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 43.39623% with 30 lines in your changes missing coverage. Please review.

Project coverage is 41.72%. Comparing base (f145992) to head (4f3d132).

Files with missing lines Patch % Lines
src/app/workflow/versions/versions-datasource.ts 42.85% 10 Missing and 6 partials ⚠️
src/app/workflow/versions/versions.component.ts 52.63% 8 Missing and 1 partial ⚠️
src/app/shared/state/paginator.service.ts 0.00% 3 Missing and 1 partial ⚠️
src/app/shared/state/paginator.store.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2023      +/-   ##
===========================================
- Coverage    41.75%   41.72%   -0.03%     
===========================================
  Files          394      395       +1     
  Lines        12320    12375      +55     
  Branches      2959     2969      +10     
===========================================
+ Hits          5144     5164      +20     
- Misses        4855     4884      +29     
- Partials      2321     2327       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant