-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEAB-6777: Improve formatting of workflow "Versions" table #2043
SEAB-6777: Improve formatting of workflow "Versions" table #2043
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## hotfix/2.13.2 #2043 +/- ##
==============================================
Coverage 41.75% 41.75%
==============================================
Files 394 394
Lines 12320 12320
Branches 2959 2959
==============================================
Hits 5144 5144
Misses 4855 4855
Partials 2321 2321 ☔ View full report in Codecov by Sentry. |
Seems a bit counter-intuitive. One other quick change would be to move verified into the overview page. Metrics basically replaces verified going forward. |
|
||
.mat-cell:not(:first-of-type), | ||
.mat-header-cell:not(:first-of-type) { | ||
padding-left: 1rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would recommend adding a comment about why these styles override the default
Lines 1249 to 1259 in f145992
.mat-cell:not(:first-of-type), | |
.mat-header-cell:not(:first-of-type) { | |
padding-left: 1.6rem; | |
} | |
/* Material says it should have 16dp to the left and right, sadly Angular Material does not */ | |
.mat-cell:not(:last-of-type), | |
.mat-header-cell:not(:last-of-type), | |
table th { | |
padding-right: 1.6rem; | |
} |
Quality Gate passedIssues Measures |
Description
This PR improves the workflow page's "Versions" table so that it fits horizontally into our UI when the browser window is wide. Previously, the table was too wide for space afforded to it by our UI, causing the rightmost elements to be hidden behind other elements, wide content to be wrapped over multiple lines, and a scrollbar to appear at bottom.
Specifically, this PR:
These changes allow the column headers to fit within the available space, and provide extra horizontal space that columns containing wide content can scale into.
These changes make a big difference, improving the spacing and flow of the table for most workflows. Arguably, the table is less useful because we now can't sort some columns, but IMHO, the readability improvement greatly outweighs any drawbacks.
Before (develop):
After (this PR):
The tool table contains less information, and didn't need these changes.
At narrow browser widths, the table still gets mangled/hidden. A possible next step might be to remove the "information circles" and instead directly link the table heading text to the documentation.
Review Instructions
Scale your browser to maximum width, view a workflow's "Versions" table, and confirm that it fits horizontally and that there is no scroll bar. Do the same for some other types of workflows.
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6777
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
npm run build
markdown-wrapper
component, which does extra sanitizationnpm audit
and ensure you are not introducing new vulnerabilities