Merge pull request #452 from dora-team/rename-gcb-pubsub-topic

rename cloud build pubsub topic
dora-team · May 4, 2023 · 33f8f33 · 33f8f33
2 parents d1bfdd6 + fa65862
commit 33f8f33
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/terraform/modules/fourkeys-cloud-build-parser/README.md b/terraform/modules/fourkeys-cloud-build-parser/README.md
@@ -1,3 +1,8 @@
+This module creates the pubsub topic and parser for Cloud Build. The name of the pubsub topic is important! 
+
+Cloud Build is designed so that if a topic exists named `cloud-builds`, build events are automatically written to it. But that topic is not created by default, [it has to be deliberately created](https://cloud.google.com/build/docs/subscribe-build-notifications#receiving_build_notifications).
+
+
 <!-- BEGIN_TF_DOCS -->
 ## Requirements
 

diff --git a/terraform/modules/fourkeys-cloud-build-parser/main.tf b/terraform/modules/fourkeys-cloud-build-parser/main.tf
@@ -46,7 +46,7 @@ resource "google_cloud_run_service" "cloudbuild_parser" {
 
 resource "google_pubsub_topic" "cloudbuild" {
   project = var.project_id
-  name    = "cloudbuild"
+  name    = "cloud-builds"
 }
 
 resource "google_pubsub_topic_iam_member" "service_account_editor" {