Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix instructions for setting up Nginx #33132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix instructions for setting up Nginx #33132

wants to merge 1 commit into from

Conversation

kant2002
Copy link

@kant2002 kant2002 commented Jul 22, 2024 •
edited by Rick-Anderson
Loading

Fixes #33159

Internal previews

📄 File 🔗 Preview link
aspnetcore/host-and-deploy/linux-nginx.md Host ASP.NET Core on Linux with Nginx

@Rick-Anderson
Copy link
Contributor

@kant2002 I don't see any differences. What's changed?

@kant2002
Copy link
Author

I remove http. Since that’s part inside nginx.conf where sites-available included

@Rick-Anderson
Copy link
Contributor

Rick-Anderson commented Jul 24, 2024 •
edited
Loading

@kant2002 got it thanks, just these two changes?

image

Per CoPilot, the only difference is the http block has been removed.

@kant2002 Is the following correct?
The http block not necessary as it's the default context in Nginx configuration files

@javiercn please review

@kant2002
Copy link
Author

@Rick-Anderson yes. it's correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn Awaiting requested review from javiercn

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Nginx instructions
2 participants
@kant2002 @Rick-Anderson