Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backport-base.yml to quote branch names #15201

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

baronfel
Copy link
Member

It's kind of hard to see the branch name in question in the error when you typo a branch name:

image

So if we quote the branch names being used instead in the error messages, that might be a more clear signal?

To double check:

@edvilme
Copy link
Member

edvilme commented Oct 24, 2024

Maybe adding bold or backticks ` could make them stand out more? (on the first string. Not sure if others are parsed as markdown?)

@baronfel
Copy link
Member Author

@edvilme I thought about that a bit, but for the errors reported during the CI run I'm not familiar with what syntax is allowed. The message that's posted back to the requesting PR could definitely be formatted more strongly, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants