More WriteGather fixes #109826
Open
More WriteGather fixes #109826
+71
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adamsitnik
commented
Nov 14, 2024
adamsitnik
commented
- macOS does not define IOV_MAX, it uses UIO_MAXIOV instead
- don't run these tests in parallel, as each test cases uses more than 4 GB ram and disk
- fix the test: handle incomplete reads that should happen when we hit the max buffer limit
- incomplete write fix:
- pin the buffers only once
- when re-trying, do that only for the actual reminder
…4 GB ram and disk!
…the max buffer limit
- pin the buffers only once - when re-trying, do that only for the actual reminder
|
Tagging subscribers to this area: @dotnet/area-system-io |
This was referenced Nov 14, 2024
adamsitnik
commented
Nov 14, 2024
| ReadOnlyMemory<byte> buffer = buffers[i]; | ||
| totalBytesToWrite += buffer.Length; | ||
|
|
||
| MemoryHandle memoryHandle = buffer.Pin(); |
There was a problem hiding this comment.
So far, for incomplete writes we were pinning the memory for every retry attempt. I am not sure if this can create some kind of edge case bugs, but I think we can do it just once, before we enter the main loop
adamsitnik
commented
Nov 14, 2024
| { | ||
| if (asyncMethod) | ||
| { | ||
| await RandomAccess.WriteAsync(sfh, writeBuffers, fileOffset); | ||
| bytesRead = await RandomAccess.ReadAsync(sfh, readBuffers, fileOffset); |
There was a problem hiding this comment.
this was a test bug, the test assumed that the read won't ever be a partial read
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.