Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(carousel): respect reduced-motion during autoplay #2319

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

saiponnada
Copy link
Contributor

Description

Fixes #2300

Context

If user has reduced motion setting turned on at OS level, the carousel doesnot autoplay by respecting the prefers-reduced-motion media query.

Reused the existing useReducedMotion code from expressive loader(moved to common/dom) for better component sharing.

@saiponnada saiponnada self-assigned this Nov 6, 2024
Copy link

changeset-bot bot commented Nov 6, 2024

🦋 Changeset detected

Latest commit: e110e48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one questions...

src/common/dom/index.ts Show resolved Hide resolved
Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/common/dom/index.ts Show resolved Hide resolved
@saiponnada saiponnada merged commit a41ae29 into 14.5.0 Nov 8, 2024
5 checks passed
@saiponnada saiponnada deleted the carousel-motion branch November 8, 2024 19:25
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants