Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22033] Release participant_stateless secure builtin writer history change when authentication has finished #5386

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Nov 6, 2024

Description

SecurityManager did not ensure that participant_stateless_secure_writer history changes were released when the remote participant was authenticated, leading to a high resource utilization.
This PR:

  • Decreases the default initial preallocated pool payload sizes experimentally:
    • Participant stateless was 6292 bytes, so it was left to the closest (2^n), 8192.
    • Participant secure volatile was 692, so it was left to 1024.
  • Makes the participant stateless secure writer history to remove the change when participants cryptography succeeds. In this way we ensure that authentication has finished in both sides. This was important because having authorized the remote is not a sufficient condition to remove the change as the remote may require us to resend until it completes the authentication with us.

Addition Notes:

  • A follow up PR will be made to configure the pool from the RTPSParticipantAllocationAttributes.
  • The temporal commit has to be removed after the review has finished.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.2.0 milestone Nov 6, 2024
@Mario-DL Mario-DL changed the title [22033] Release participant_stateless secure builtin writer when authentication has finished [22033] Release participant_stateless secure builtin writer history change when authentication has finished Nov 6, 2024
@Mario-DL Mario-DL force-pushed the fix/22033 branch 2 times, most recently from 2caa14e to 8dbc8d2 Compare November 7, 2024 12:32
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima November 7, 2024 12:33
@github-actions github-actions bot added the ci-pending PR which CI is running label Nov 7, 2024
@MiguelCompany MiguelCompany merged commit b414621 into master Nov 12, 2024
16 of 17 checks passed
@MiguelCompany MiguelCompany deleted the fix/22033 branch November 12, 2024 07:03
@MiguelCompany
Copy link
Member

@Mergifyio backport 3.1.x 3.0.x 2.14.x

mergify bot pushed a commit that referenced this pull request Nov 12, 2024
…when authentication has finished (#5386)

* TMP: REMOVE THIS COMMIT

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #22033: BB test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #22033: Modify secure builtins initial payload size

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #22033: Fix: release stateless msg payload pool when participant cryptography succeeds

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit b414621)
mergify bot pushed a commit that referenced this pull request Nov 12, 2024
…when authentication has finished (#5386)

* TMP: REMOVE THIS COMMIT

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #22033: BB test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #22033: Modify secure builtins initial payload size

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #22033: Fix: release stateless msg payload pool when participant cryptography succeeds

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit b414621)
mergify bot pushed a commit that referenced this pull request Nov 12, 2024
…when authentication has finished (#5386)

* TMP: REMOVE THIS COMMIT

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #22033: BB test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #22033: Modify secure builtins initial payload size

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #22033: Fix: release stateless msg payload pool when participant cryptography succeeds

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit b414621)
@MiguelCompany
Copy link
Member

@Mergifyio backport 2.10.x

Copy link
Contributor

mergify bot commented Nov 12, 2024

backport 2.10.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 12, 2024
…when authentication has finished (#5386)

* TMP: REMOVE THIS COMMIT

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #22033: BB test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #22033: Modify secure builtins initial payload size

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #22033: Fix: release stateless msg payload pool when participant cryptography succeeds

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit b414621)
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not have reproducible environment anymore, but description and implementation loos good. thanks for letting me know.

MiguelCompany pushed a commit that referenced this pull request Nov 14, 2024
…when authentication has finished (#5386) (#5391)

* TMP: REMOVE THIS COMMIT

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #22033: BB test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #22033: Modify secure builtins initial payload size

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #22033: Fix: release stateless msg payload pool when participant cryptography succeeds

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit b414621)

Co-authored-by: Mario Domínguez López <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Nov 14, 2024
…when authentication has finished (#5386) (#5392)

* TMP: REMOVE THIS COMMIT

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #22033: BB test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #22033: Modify secure builtins initial payload size

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #22033: Fix: release stateless msg payload pool when participant cryptography succeeds

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit b414621)

Co-authored-by: Mario Domínguez López <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SECURITY Error] WriterHistory cannot add the CacheChange_t -> Function on_process_handshake
3 participants