-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21886] Feature: Windows ci example testing #5397
Open
Mario-DL
wants to merge
7
commits into
master
Choose a base branch
from
feature/21886/hello_world
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario-DL <[email protected]>
Signed-off-by: Mario-DL <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario-DL <[email protected]>
Signed-off-by: Mario-DL <[email protected]>
Signed-off-by: Mario-DL <[email protected]>
…ples Signed-off-by: Mario Dominguez <[email protected]>
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
November 12, 2024 14:43
Mario-DL
changed the title
[21886] Feature: Windows ci hello world example testing and refactor
[21886] Feature: Windows ci example testing
Nov 12, 2024
Mario-DL
added
needs-review
PR that is ready to be reviewed
and removed
ci-pending
PR which CI is running
labels
Nov 13, 2024
Mario-DL
commented
Nov 13, 2024
@@ -11,33 +11,32 @@ | |||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
# See the License for the specific language governing permissions and | |||
# limitations under the License. | |||
version: "3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version has been removed from all compose files since it throws a warning of deprecation and can create confusion
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces example testing in windows (for the moment, just the
hello_world_example
) byDockerfile
hello_world
examplematched
so the publisher does not start publishing until it has discovered a minimum of participants.Follow up work
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist