Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21886] Feature: Windows ci example testing #5397

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Nov 12, 2024

Description

This PR introduces example testing in windows (for the moment, just the hello_world_example) by

  • Refactoring the current ci example testing so that the docker composes can be used for Linux and Windows.
  • Creating a new cmake target in which the windows testing image is created with the provided Dockerfile
  • It also adds a new cli argument to the hello_world example matched so the publisher does not start publishing until it has discovered a minimum of participants.

Follow up work

  • Include the rest of the examples in the testing.
  • Maybe separate the windows ci in two jobs: one for building the core library and the other one for testing

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.2.0 milestone Nov 12, 2024
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima November 12, 2024 14:43
@github-actions github-actions bot added the ci-pending PR which CI is running label Nov 12, 2024
@Mario-DL Mario-DL changed the title [21886] Feature: Windows ci hello world example testing and refactor [21886] Feature: Windows ci example testing Nov 12, 2024
@Mario-DL Mario-DL added needs-review PR that is ready to be reviewed and removed ci-pending PR which CI is running labels Nov 13, 2024
@@ -11,33 +11,32 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
version: "3"
Copy link
Member Author

@Mario-DL Mario-DL Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version has been removed from all compose files since it throws a warning of deprecation and can create confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review PR that is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant