Remove scm-extra #293
Merged
Remove scm-extra #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 10, 2023
Closed
|
BTW, I think the CI failure is unrelated to the PR - apparently caused by a recent shortage of executor nodes for Linux. |
marcdumais-work
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
LGTM, thanks @danepowell! I will merge after CI has passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Remove theia/scm-extra package from browser blueprint, per advice in eclipse-theia/theia#10786 (comment)
How to test
Verify that the (broken) History option is gone from the View menu, but no other functionality is impacted.
Review checklist
Reminder for reviewers