Allow task due date inline editing if no date #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added place holder text for Due date so the inline editing is available for nil due date
anthonycrumley
requested changes
Sep 13, 2017
| @@ -123,7 +123,7 @@ | |||
| data-source="<%= User.editable_options %>"><%= task.owner.try(:email) %></a></td> | |||
| <td><%= task.network_event.schools.map {|school| school.name}.join(", ") %></td> | |||
| <td class="date-cell" id="date_<%= task.id %>"> | |||
| <span class="date-view"><%= task.formatted_due_date %></span> | |||
| <span class="date-view"><%= task.formatted_due_date.present? ? task.formatted_due_date : 'Add Due Date' %></span> | |||
There was a problem hiding this comment.
@vishwasja It may be better to modify NetworkEventTask#formatted_due_date to return text when no date has been set. The date_modifier field would probably be better text since it would give an indication of when the date would be relative to the event. See example of an event with the date_modifier text below.
=> #<NetworkEventTask id: 65, name: "Schedule transportation", completed_at: nil, common_task_id: 2, network_event_id: 22, user_id: 1, created_at: "2017-09-13 17:13:49", updated_at: "2017-09-13 17:13:49", due_date: nil, date_modifier: "1 week before event", owner_id: nil>
…_due_date with the date_modifier value
anthonycrumley
approved these changes
Sep 13, 2017
|
@vishwasja Thanks for all the help you give to Birmingham's school children!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow task due date inplace editing if no date #555
Fix event page New Task Form dropdown widths #554