Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docusaurus-theme): fill Codesandbox icon with currentColor #8127

Conversation

weronikaolejniczak
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak commented Nov 8, 2024

Summary

The Codesandbox icon in the footer of each example in EUI+ doesn't change the color depending on the theme (dark / light mode).

QA

  1. Open the new docs.
  2. Navigate to any component page (e.g. Accordion).
  3. Notice the component preview. In the footer, there's a Codesandbox icon.
  4. Switch themes using the toggle in the top right of the page.
  5. Verify that the Codesandbox icon is visible. In light mode it should be black, in dark mode white.
Screen.Recording.2024-11-08.at.19.34.42.mov

@weronikaolejniczak weronikaolejniczak requested a review from a team as a code owner November 8, 2024 18:36
@weronikaolejniczak weronikaolejniczak added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels Nov 8, 2024
@mgadewoll
Copy link
Contributor

mgadewoll commented Nov 11, 2024

@weronikaolejniczak

Nothing is applicable... 👀

A general fyi for the "QA" section:
We have the general QA checklist but besides that you can add your own QA instructions.
E.g. something like this:

- open EUI+ docs (example link here)
- toggle the color mode switch in the page header
- [ ] verify that the codesandbox icon on code examples updates its color accordingly on color mode change

There is no expected pattern for this, just in general some instructions to follow for people to know what to look at and verify considering someone might see it and not fully know what it's about (this PR is simple but more as a common approach)

@weronikaolejniczak
Copy link
Contributor Author

@mgadewoll that's a good point 👌🏻 I updated the description with proper QA instructions.

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@weronikaolejniczak weronikaolejniczak merged commit 50e3c74 into elastic:main Nov 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants