fix(GotDownloader): add URL to 404 error message (#146)

electron · Feb 10, 2020 · 16c4ec2 · 16c4ec2
1 parent 2422ca4
commit 16c4ec2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/GotDownloader.ts b/src/GotDownloader.ts
@@ -16,6 +16,9 @@ export class GotDownloader implements Downloader<any> {
       downloadStream.pipe(writeStream);
 
       downloadStream.on('error', error => {
+        if (error.name === 'HTTPError' && error.statusCode === 404) {
+          error.message += ` for ${error.url}`;
+        }
         if (writeStream.destroy) {
           writeStream.destroy(error);
         }

diff --git a/test/GotDownloader.network.spec.ts b/test/GotDownloader.network.spec.ts
@@ -25,12 +25,10 @@ describe('GotDownloader', () => {
       const downloader = new GotDownloader();
       await withTempDirectory(async dir => {
         const testFile = path.resolve(dir, 'test.txt');
-        await expect(
-          downloader.download(
-            'https://github.com/electron/electron/releases/download/v2.0.18/bad.file',
-            testFile,
-          ),
-        ).rejects.toMatchInlineSnapshot(`[HTTPError: Response code 404 (Not Found)]`);
+        const url = 'https://github.com/electron/electron/releases/download/v2.0.18/bad.file';
+        await expect(downloader.download(url, testFile)).rejects.toMatchInlineSnapshot(
+          `[HTTPError: Response code 404 (Not Found) for ${url}]`,
+        );
       });
     });