Fix sass deprecations #562
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didoo
approved these changes
Oct 31, 2024
tests/dummy/app/styles/app.scss
Outdated
| @@ -1,10 +1,10 @@ | |||
| @import 'variables/variables'; | |||
| @use 'variables/_variables' as *; | |||
There was a problem hiding this comment.
[question] I don't think the underscore is needed anymore (to have Sass ignore certain files). Is it some form of convention used locally? (I see the other files are "imported/used" without the underscore.
| @use 'object-patterns/object-patterns'; | ||
| @use 'pages/pages'; | ||
| @use 'typography/typography'; | ||
| @use 'utilities/utilities'; | ||
|
|
||
| html { |
There was a problem hiding this comment.
[suggestion] not related to this PR, but I would suggest to move the global declarations in a dedicated file (eg. global.scss and import (@use) it as first item after the variables, before the other files (components, patterns, etc).
There was a problem hiding this comment.
Thank you for the suggestion! I've captured it in a separate issue: #563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since sass no longer supports
@import, needed to switch it up to use@useinstead, which also meant adding a few additional use declarations in files that were pulling in the variables.Going to try to find someone who regularly uses sass to review since I haven't used sass in this way in a long time and I'm not entirely positive it's the correct change.