chore: use references for tsc, add checks to schema-record, bun to ru…

…n scripts (#9051) * use references for tsc, add checks to schema-record, bun to run scripts * fixup lint * fix lint
emberjs · Oct 24, 2023 · 2ca4a57 · 2ca4a57
1 parent addf467
commit 2ca4a57
Show file tree

Hide file tree

Showing 65 changed files with 408 additions and 179 deletions.
diff --git a/packages/-ember-data/package.json b/packages/-ember-data/package.json
@@ -15,9 +15,9 @@
     "lint": "eslint . --quiet --cache --cache-strategy=content --ext .js,.ts,.mjs,.cjs",
     "move-dts": "bun ../../scripts/copy-declarations.mjs addon",
     "build:types": "tsc --build",
-    "_build": "pnpm build:types && pnpm move-dts",
-    "prepack": "pnpm build && cd ../../ && pnpm build:docs",
-    "_syncPnpm": "pnpm sync-dependencies-meta-injected"
+    "_build": "bun run build:types && bun run move-dts",
+    "prepack": "pnpm build && cd ../../ && bun run build:docs",
+    "_syncPnpm": "bun run sync-dependencies-meta-injected"
   },
   "files": [
     "dist/docs",

diff --git a/packages/-ember-data/tsconfig.json b/packages/-ember-data/tsconfig.json
@@ -43,4 +43,17 @@
       "@ember-data/env": ["../private-build-infra/virtual-packages/env.d.ts"],
     }
   },
+  "references": [
+    { "path": "../adapter" },
+    { "path": "../graph" },
+    { "path": "../json-api" },
+    { "path": "../legacy-compat" },
+    { "path": "../model" },
+    { "path": "../request" },
+    { "path": "../request-utils" },
+    { "path": "../serializer" },
+    { "path": "../store" },
+    { "path": "../tracking" },
+    { "path": "../core-types" },
+  ]
 }
diff --git a/packages/active-record/package.json b/packages/active-record/package.json
@@ -76,9 +76,9 @@
     "lint": "eslint . --quiet --cache --cache-strategy=content --ext .js,.ts,.mjs,.cjs",
     "build:types": "tsc --build",
     "build:client": "rollup --config && babel ./addon --out-dir addon --plugins=../private-build-infra/src/transforms/babel-plugin-transform-ext.js",
-    "_build": "pnpm build:client && pnpm build:types",
+    "_build": "bun run build:client && bun run build:types",
     "prepack": "pnpm build",
-    "_syncPnpm": "pnpm sync-dependencies-meta-injected"
+    "_syncPnpm": "bun run sync-dependencies-meta-injected"
   },
   "ember-addon": {
     "main": "addon-main.js",

diff --git a/packages/active-record/tsconfig.json b/packages/active-record/tsconfig.json
@@ -42,4 +42,11 @@
       "@ember-data/env": ["../private-build-infra/virtual-packages/env.d.ts"],
     }
   },
+  "references": [
+    { "path": "../request" },
+    { "path": "../request-utils" },
+    { "path": "../store" },
+    { "path": "../tracking" },
+    { "path": "../core-types" },
+  ]
 }
diff --git a/packages/adapter/package.json b/packages/adapter/package.json
@@ -17,9 +17,9 @@
     "lint": "eslint . --quiet --cache --cache-strategy=content --ext .js,.ts,.mjs,.cjs",
     "build:types": "tsc --build",
     "build:client": "rollup --config && babel ./addon --out-dir addon --plugins=../private-build-infra/src/transforms/babel-plugin-transform-ext.js",
-    "_build": "pnpm build:client && pnpm build:types",
+    "_build": "bun run build:client && bun run build:types",
     "prepack": "pnpm build",
-    "_syncPnpm": "pnpm sync-dependencies-meta-injected"
+    "_syncPnpm": "bun run sync-dependencies-meta-injected"
   },
   "ember-addon": {
     "main": "addon-main.js",

diff --git a/packages/adapter/tsconfig.json b/packages/adapter/tsconfig.json
@@ -46,4 +46,14 @@
       "@ember-data/env": ["../private-build-infra/virtual-packages/env.d.ts"],
     }
   },
+  "references": [
+    { "path": "../graph" },
+    { "path": "../json-api" },
+    { "path": "../legacy-compat" },
+    { "path": "../request" },
+    { "path": "../request-utils" },
+    { "path": "../store" },
+    { "path": "../tracking" },
+    { "path": "../core-types" },
+  ]
 }
diff --git a/packages/core-types/package.json b/packages/core-types/package.json
@@ -16,9 +16,9 @@
     "lint": "eslint . --quiet --cache --cache-strategy=content --ext .js,.ts,.mjs,.cjs",
     "build:types": "tsc --build",
     "build:client": "rollup --config && babel ./addon --out-dir addon --plugins=../private-build-infra/src/transforms/babel-plugin-transform-ext.js",
-    "_build": "pnpm build:client && pnpm build:types",
+    "_build": "bun run build:client && bun run build:types",
     "prepack": "pnpm build",
-    "_syncPnpm": "pnpm sync-dependencies-meta-injected"
+    "_syncPnpm": "bun run sync-dependencies-meta-injected"
   },
   "files": [
     "addon",

diff --git a/packages/core-types/src/cache.ts b/packages/core-types/src/cache.ts
@@ -335,7 +335,7 @@ export interface Cache {
    * @param field
    * @returns {unknown}
    */
-  getAttr(identifier: StableRecordIdentifier, field: string): unknown;
+  getAttr(identifier: StableRecordIdentifier, field: string): Value | undefined;
 
   /**
    * Mutate the data for an attribute in the cache

diff --git a/packages/debug/package.json b/packages/debug/package.json
@@ -15,7 +15,7 @@
   "directories": {},
   "scripts": {
     "lint": "eslint . --quiet --cache --cache-strategy=content --ext .js,.ts,.mjs,.cjs",
-    "_syncPnpm": "pnpm sync-dependencies-meta-injected"
+    "_syncPnpm": "bun run sync-dependencies-meta-injected"
   },
   "peerDependencies": {
     "@ember-data/store": "workspace:5.5.0-alpha.11",

diff --git a/packages/diagnostic/package.json b/packages/diagnostic/package.json
@@ -64,10 +64,10 @@
     "build:tests": "rm -rf dist-test && cp -R test dist-test && mkdir -p dist-test/@warp-drive && cp -R dist dist-test/@warp-drive/diagnostic",
     "build:types": "tsc --build",
     "build:runtime": "rollup --config",
-    "_build": "pnpm build:runtime && pnpm build:types",
+    "_build": "bun run build:runtime && bun run build:types",
     "start": "rollup --config --watch",
     "prepack": "pnpm build",
-    "_syncPnpm": "pnpm sync-dependencies-meta-injected"
+    "_syncPnpm": "bun run sync-dependencies-meta-injected"
   },
   "peerDependencies": {
     "@ember/test-helpers": ">= 3.2.0",

diff --git a/packages/eslint-plugin-ember-data/package.json b/packages/eslint-plugin-ember-data/package.json
@@ -16,6 +16,6 @@
     "pnpm-sync-dependencies-meta-injected": "0.0.10"
   },
   "scripts": {
-    "_syncPnpm": "pnpm sync-dependencies-meta-injected"
+    "_syncPnpm": "bun run sync-dependencies-meta-injected"
   }
 }
diff --git a/packages/graph/package.json b/packages/graph/package.json
@@ -16,9 +16,9 @@
     "lint": "eslint . --quiet --cache --cache-strategy=content --ext .js,.ts,.mjs,.cjs",
     "build:types": "tsc --build",
     "build:client": "rollup --config && babel ./addon --out-dir addon --plugins=../private-build-infra/src/transforms/babel-plugin-transform-ext.js",
-    "_build": "pnpm build:client && pnpm build:types",
+    "_build": "bun run build:client && bun run build:types",
     "prepack": "pnpm build",
-    "_syncPnpm": "pnpm sync-dependencies-meta-injected"
+    "_syncPnpm": "bun run sync-dependencies-meta-injected"
   },
   "files": [
     "unstable-preview-types",

diff --git a/packages/graph/tsconfig.json b/packages/graph/tsconfig.json
@@ -42,4 +42,10 @@
       "@ember-data/env": ["../private-build-infra/virtual-packages/env.d.ts"],
     }
   },
+  "references": [
+    { "path": "../request" },
+    { "path": "../store" },
+    { "path": "../tracking" },
+    { "path": "../core-types" },
+  ]
 }
diff --git a/packages/holodeck/package.json b/packages/holodeck/package.json
@@ -43,10 +43,10 @@
   "scripts": {
     "build:types": "tsc --build",
     "build:client": "rollup --config",
-    "_build": "pnpm build:client && pnpm build:types",
+    "_build": "bun run build:client && bun run build:types",
     "start": "rollup --config --watch",
     "prepack": "pnpm build",
-    "_syncPnpm": "pnpm sync-dependencies-meta-injected"
+    "_syncPnpm": "bun run sync-dependencies-meta-injected"
   },
   "peerDependencies": {
     "@ember-data/request": "workspace:5.5.0-alpha.11",

diff --git a/packages/holodeck/tsconfig.json b/packages/holodeck/tsconfig.json
@@ -43,5 +43,9 @@
     "inlineSources": true,
 
     "baseUrl": "client"
-  }
+  },
+  "references": [
+    { "path": "../request" },
+    { "path": "../core-types" },
+  ]
 }
diff --git a/packages/json-api/package.json b/packages/json-api/package.json
@@ -16,9 +16,9 @@
     "lint": "eslint . --quiet --cache --cache-strategy=content --ext .js,.ts,.mjs,.cjs",
     "build:types": "tsc --build",
     "build:client": "rollup --config && babel ./addon --out-dir addon --plugins=../private-build-infra/src/transforms/babel-plugin-transform-ext.js",
-    "_build": "pnpm build:client && pnpm build:types",
+    "_build": "bun run build:client && bun run build:types",
     "prepack": "pnpm build",
-    "_syncPnpm": "pnpm sync-dependencies-meta-injected"
+    "_syncPnpm": "bun run sync-dependencies-meta-injected"
   },
   "ember-addon": {
     "main": "addon-main.js",

diff --git a/packages/json-api/src/-private/cache.ts b/packages/json-api/src/-private/cache.ts
@@ -1086,7 +1086,7 @@ export default class JSONAPICache implements Cache {
    * @param field
    * @returns {unknown}
    */
-  getAttr(identifier: StableRecordIdentifier, attr: string): unknown {
+  getAttr(identifier: StableRecordIdentifier, attr: string): Value | undefined {
     const cached = this.__peek(identifier, true);
     if (cached.localAttrs && attr in cached.localAttrs) {
       return cached.localAttrs[attr];

diff --git a/packages/json-api/tsconfig.json b/packages/json-api/tsconfig.json
@@ -43,4 +43,12 @@
       "@ember-data/env": ["../private-build-infra/virtual-packages/env.d.ts"],
     }
   },
+  "references": [
+    { "path": "../graph" },
+     { "path": "../request" },
+    { "path": "../request-utils" },
+    { "path": "../store" },
+    { "path": "../tracking" },
+    { "path": "../core-types" },
+  ]
 }
diff --git a/packages/legacy-compat/package.json b/packages/legacy-compat/package.json
@@ -43,9 +43,9 @@
     "lint": "eslint . --quiet --cache --cache-strategy=content --ext .js,.ts,.mjs,.cjs",
     "build:types": "tsc --build",
     "build:client": "rollup --config && babel ./addon --out-dir addon --plugins=../private-build-infra/src/transforms/babel-plugin-transform-ext.js",
-    "_build": "pnpm build:client && pnpm build:types",
+    "_build": "bun run build:client && bun run build:types",
     "prepack": "pnpm build",
-    "_syncPnpm": "pnpm sync-dependencies-meta-injected"
+    "_syncPnpm": "bun run sync-dependencies-meta-injected"
   },
   "ember-addon": {
     "main": "addon-main.js",

diff --git a/packages/legacy-compat/tsconfig.json b/packages/legacy-compat/tsconfig.json
@@ -42,4 +42,13 @@
       "@ember-data/env": ["../private-build-infra/virtual-packages/env.d.ts"],
     }
   },
+  "references": [
+    { "path": "../graph" },
+    { "path": "../json-api" },
+    { "path": "../request" },
+    { "path": "../request-utils" },
+    { "path": "../store" },
+    { "path": "../tracking" },
+    { "path": "../core-types" },
+  ]
 }
diff --git a/packages/model/package.json b/packages/model/package.json
@@ -16,11 +16,11 @@
   "scripts": {
     "lint": "eslint . --quiet --cache --cache-strategy=content --ext .js,.ts,.mjs,.cjs",
     "move-dts": "bun ../../scripts/copy-declarations.mjs src",
-    "build:types": "tsc --build && pnpm move-dts",
+    "build:types": "tsc --build && bun run move-dts",
     "build:client": "rollup --config && babel ./addon --out-dir addon --plugins=../private-build-infra/src/transforms/babel-plugin-transform-ext.js",
-    "_build": "pnpm build:client && pnpm build:types",
+    "_build": "bun run build:client && bun run build:types",
     "prepack": "pnpm build",
-    "_syncPnpm": "pnpm sync-dependencies-meta-injected"
+    "_syncPnpm": "bun run sync-dependencies-meta-injected"
   },
   "ember-addon": {
     "main": "addon-main.js",

diff --git a/packages/model/tsconfig.json b/packages/model/tsconfig.json
@@ -44,4 +44,14 @@
       "@ember-data/env": ["../private-build-infra/virtual-packages/env.d.ts"],
     }
   },
+  "references": [
+    { "path": "../graph" },
+    { "path": "../json-api" },
+    { "path": "../legacy-compat" },
+    { "path": "../request" },
+    { "path": "../request-utils" },
+    { "path": "../store" },
+    { "path": "../tracking" },
+    { "path": "../core-types" },
+  ]
 }
diff --git a/packages/private-build-infra/package.json b/packages/private-build-infra/package.json
@@ -11,7 +11,7 @@
   "author": "",
   "directories": {},
   "scripts": {
-    "_syncPnpm": "pnpm sync-dependencies-meta-injected"
+    "_syncPnpm": "bun run sync-dependencies-meta-injected"
   },
   "dependencies": {
     "@babel/core": "^7.23.2",

diff --git a/packages/request-utils/package.json b/packages/request-utils/package.json
@@ -47,9 +47,9 @@
     "lint": "eslint . --quiet --cache --cache-strategy=content --ext .js,.ts,.mjs,.cjs",
     "build:types": "tsc --build",
     "build:client": "rollup --config && babel ./addon --out-dir addon --plugins=../private-build-infra/src/transforms/babel-plugin-transform-ext.js",
-    "_build": "pnpm build:client && pnpm build:types",
+    "_build": "bun run build:client && bun run build:types",
     "prepack": "pnpm build",
-    "_syncPnpm": "pnpm sync-dependencies-meta-injected"
+    "_syncPnpm": "bun run sync-dependencies-meta-injected"
   },
   "ember-addon": {
     "main": "addon-main.js",

diff --git a/packages/request-utils/tsconfig.json b/packages/request-utils/tsconfig.json
@@ -44,5 +44,8 @@
     "types": [
       "ember-source/types"
     ]
-  }
+  },
+  "references": [
+    { "path": "../core-types" },
+  ]
 }
diff --git a/packages/request/package.json b/packages/request/package.json
@@ -18,9 +18,9 @@
     "lint": "eslint . --quiet --cache --cache-strategy=content --ext .js,.ts,.mjs,.cjs",
     "build:types": "tsc --build",
     "build:client": "rollup --config && babel ./addon --out-dir addon --plugins=../private-build-infra/src/transforms/babel-plugin-transform-ext.js",
-    "_build": "pnpm build:client && pnpm build:types",
+    "_build": "bun run build:client && bun run build:types",
     "prepack": "pnpm build",
-    "_syncPnpm": "pnpm sync-dependencies-meta-injected"
+    "_syncPnpm": "bun run sync-dependencies-meta-injected"
   },
   "files": [
     "unstable-preview-types",

diff --git a/packages/request/tsconfig.json b/packages/request/tsconfig.json
@@ -44,5 +44,8 @@
     "paths": {
       "@ember-data/env": ["../../private-build-infra/virtual-packages/env.d.ts"],
     }
-  }
+  },
+  "references": [
+    { "path": "../core-types" },
+  ]
 }
diff --git a/packages/rest/package.json b/packages/rest/package.json
@@ -51,9 +51,9 @@
     "lint": "eslint . --quiet --cache --cache-strategy=content --ext .js,.ts,.mjs,.cjs",
     "build:types": "tsc --build",
     "build:client": "rollup --config && babel ./addon --out-dir addon --plugins=../private-build-infra/src/transforms/babel-plugin-transform-ext.js",
-    "_build": "pnpm build:client && pnpm build:types",
+    "_build": "bun run build:client && bun run build:types",
     "prepack": "pnpm build",
-    "_syncPnpm": "pnpm sync-dependencies-meta-injected"
+    "_syncPnpm": "bun run sync-dependencies-meta-injected"
   },
   "ember-addon": {
     "main": "addon-main.js",

diff --git a/packages/rest/tsconfig.json b/packages/rest/tsconfig.json
@@ -42,4 +42,11 @@
       "@ember-data/env": ["../private-build-infra/virtual-packages/env.d.ts"],
     }
   },
+  "references": [
+    { "path": "../request" },
+    { "path": "../request-utils" },
+    { "path": "../store" },
+    { "path": "../tracking" },
+    { "path": "../core-types" },
+  ]
 }
diff --git a/packages/schema-record/.eslintrc.cjs b/packages/schema-record/.eslintrc.cjs
@@ -0,0 +1,26 @@
+const imports = require('@warp-drive/internal-config/eslint/imports.cjs');
+const parser = require('@warp-drive/internal-config/eslint/parser.cjs');
+const isolation = require('@warp-drive/internal-config/eslint/isolation.cjs');
+const ignore = require('@warp-drive/internal-config/eslint/ignore.cjs');
+const node = require('@warp-drive/internal-config/eslint/node.cjs');
+const base = require('@warp-drive/internal-config/eslint/base.cjs');
+const typescript = require('@warp-drive/internal-config/eslint/typescript.cjs');
+
+module.exports = {
+  ...parser.defaults(),
+
+  plugins: [...base.plugins(), ...imports.plugins()],
+  extends: [...base.extend()],
+  rules: Object.assign(
+    base.rules(),
+    imports.rules(),
+    isolation.rules({
+      allowedImports: [],
+    }),
+    {}
+  ),
+
+  ignorePatterns: ignore.ignoreRules(),
+
+  overrides: [node.defaults(), typescript.defaults()],
+};