Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

feat: add customImage #25

Closed
wants to merge 0 commits into from
Closed

Conversation

lenglet-k
Copy link
Contributor

Resolve this issue: #24

Copy link
Owner

@eshepelyuk eshepelyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello

  1. I suggest to add a new boolean parameter to registry.image object that will instruct template to auto detect and add image suffix or not.

  2. I do prefer this PR to be split into 2 : for image suffix and image pull secrets. the latter one is will be merged definitely faster.

@lenglet-k
Copy link
Contributor Author

ok i will do that

@lenglet-k
Copy link
Contributor Author

lenglet-k commented Dec 6, 2023

imagePullSecrets PR: #26

for the 1 point the customImage is not good for you ? You prefer that:

registry:
  image:
#   one below value can be true
    sql: false # if true  set sql image
    kafka: false # if true  set kafkasql image
    mem: true # if true  set mem image, is default value like now
    custom: false #  if true set custom image define in image registry.image
# or maybe that
    customImage:
      sql: false # if true  set sql image
      kafka: false # if true  set kafkasql image
      mem: true # if true  set mem image, is default value like now
      custom: false #  if true set custom image define in image registry.image

@eshepelyuk
Copy link
Owner

imagePullSecrets PR: #26

for the 1 point the customImage is not good for you ? You prefer that:

registry:
  image:
#   one below value can be true
    sql: false # if true  set sql image
    kafka: false # if true  set kafkasql image
    mem: true # if true  set mem image, is default value like now
    custom: false #  if true set custom image define in image registry.image
# or maybe that
    customImage:
      sql: false # if true  set sql image
      kafka: false # if true  set kafkasql image
      mem: true # if true  set mem image, is default value like now
      custom: false #  if true set custom image define in image registry.image
registry:
  image:
    .....
    persistenceSuffix: true # by default true - current behaviour, if false then no suffix added and repository + tag is used, so you can redefine custom image via repository plus tag

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants