fix: use testify instead of t.Fatal in tests/common package (part 2)

[mmorel-35]

This uses testify instead of testing for t.Fatal calls

[k8s-ci-robot]

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mmorel-35]

/assign @ahrtr

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorel-35
Once this PR has been reviewed and has the lgtm label, please ask for approval from ahrtr. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.77%. Comparing base (0f9c128) to head (08a96c5).

❗ Current head 08a96c5 differs from pull request most recent head 59a8434

Please upload reports for the commit 59a8434 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 26 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18860      +/-   ##
==========================================
- Coverage   68.80%   68.77%   -0.03%     
==========================================
  Files         420      420              
  Lines       35532    35532              
==========================================
- Hits        24448    24438      -10     
- Misses       9662     9666       +4     
- Partials     1422     1428       +6     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f9c128...59a8434. Read the comment docs.

[jmhbnz]

/ok-to-test

[mmorel-35]

/test pull-etcd-integration-1-cpu-amd64