Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to constrain fabio instance to specific consul namespace #812

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

baabgai
Copy link

@baabgai baabgai commented Jan 11, 2021

This helps to use fabio in a multi tenant environment by allowing to register a fabio instance in a specific consul namespace. All services that will be picked up with the specified tagprefix by this instance only come from the same consul namespace.

@CLAassistant
Copy link

CLAassistant commented Jan 11, 2021

CLA assistant check
All committers have signed the CLA.

@ketzacoatl
Copy link

@leprechau / @pschultz / @nathanejohnson, is this contribution you would want to see in fabio? It seems useful to those of us running multiple fabio instances (each with their own tagprefix), or looking to isolate groups of services/traffic.

@pschultz
Copy link
Member

pschultz commented Feb 3, 2021

Seems very useful to me. I just can't help with the review/testing, because we're not an enterprise customer.

@nathanejohnson
Copy link
Member

I can see this being useful, but like @pschultz we are not enterprise customers so I can't test or vet this PR.

@ketzacoatl
Copy link

I'm not a gopher, so my review of the code would be meaningless. Would you be able to do a code review?

I could run tests to confirm the expected behavior.

@pschultz
Copy link
Member

pschultz commented Feb 4, 2021

The code looks fine to me. It's a pretty obvious and natural change. What I can't judge is if there are any missing places where the namespace has to be respected, but should become apparent with testing.

@aaronhurt
Copy link
Member

@baabgai are you using this patch in your environment? Can you confirm operation?

@baabgai
Copy link
Author

baabgai commented May 21, 2021

Hi @leprechau,
Yes we're using it at the moment in production and until now we didn't experience any issues with namespace addition. To be fair I have to mention that we're still in the process of setting up a multi tenant cluster where this component is used and the current production load is still rather low.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants