-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to constrain fabio instance to specific consul namespace #812
base: master
Are you sure you want to change the base?
Conversation
@leprechau / @pschultz / @nathanejohnson, is this contribution you would want to see in fabio? It seems useful to those of us running multiple fabio instances (each with their own tagprefix), or looking to isolate groups of services/traffic. |
Seems very useful to me. I just can't help with the review/testing, because we're not an enterprise customer. |
I can see this being useful, but like @pschultz we are not enterprise customers so I can't test or vet this PR. |
I'm not a gopher, so my review of the code would be meaningless. Would you be able to do a code review? I could run tests to confirm the expected behavior. |
The code looks fine to me. It's a pretty obvious and natural change. What I can't judge is if there are any missing places where the namespace has to be respected, but should become apparent with testing. |
@baabgai are you using this patch in your environment? Can you confirm operation? |
Hi @leprechau, |
a55de9d
to
04f958c
Compare
This helps to use fabio in a multi tenant environment by allowing to register a fabio instance in a specific consul namespace. All services that will be picked up with the specified tagprefix by this instance only come from the same consul namespace.