Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version, test binaries and package versions. #952

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

tristanmorgan
Copy link
Member

This one is to address the list of upstream fixes by pulling in the latest of almost every dependency we have.

its going to sit for a while just to make sure it hasn't broken anything. The Tests pass but there could be areas that the coverage didn't uncover.

@tristanmorgan tristanmorgan marked this pull request as ready for review September 8, 2024 23:30
@tristanmorgan tristanmorgan requested a review from a team September 8, 2024 23:31
Copy link
Contributor

@dcarbone dcarbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but there is no reason to use a matrix anymore with the move to a singular version to test on, and may as well just modernize the whole thing.

.github/workflows/build.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@dcarbone dcarbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one consul version bump on my last pass, otherwise I think this is good.

@aaronhurt, any comments?

Makefile Outdated Show resolved Hide resolved
@tristanmorgan tristanmorgan merged commit 596f443 into fabiolb:master Sep 9, 2024
1 check passed
@tristanmorgan tristanmorgan deleted the go_update branch September 9, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants