Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Clear Codeowners for breeze #11547

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

assignUser
Copy link
Collaborator

Breeze is an entire separate library that is not build in CI. I would like to not get notifications for the dir, the way to do this in CODEOWNERS is to specify the dir and explicitly add a CO (or none to clear).

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 15, 2024
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 29cc5b3
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6737e79f7e304e00085f23c2

@@ -29,6 +29,9 @@ CMake/ @assignUser @majetideepak
scripts/ @assignUser @majetideepak
.github/ @assignUser @majetideepak

# clear codeownership in these dirs
velox/experimental/breeze
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add @dreveman as the owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm, thanks

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only works if you have write access to the repo:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants