fix: return this from destroy()
#855
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
Arcuman
approved these changes
Jan 12, 2022
Arcuman
approved these changes
Jan 12, 2022
rprata
approved these changes
Apr 22, 2022
|
News about this PR? |
ViniciusFXavier
approved these changes
Nov 16, 2022
|
@feross pls you can review this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
This simply returns
thisfromdestroy()- quite a minor change but which brings the implemenation ofDuplexinto line with current Node implementation.Which issue (if any) does this pull request address?
For consistency with Node readable stream implementation,
destroy()should returnthis- https://nodejs.org/api/stream.html#readabledestroyerrorIs there anything you'd like reviewers to focus on?
Context: DefinitelyTyped/DefinitelyTyped#57473