Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension descriptions now reflect .vscode dir #1302

Merged

Conversation

dcarosone
Copy link
Contributor

including that image pasting is now supported natively

including that image pasting is now supported natively
@dcarosone
Copy link
Contributor Author

But I'm unclear why we no longer recommend Markdown All-in-One?
I've moved it below the break, unless there's a reason it's no longer recommended at all? PR marked draft until this is clarified.

@riccardoferretti
Copy link
Collaborator

My bad, markdown all in one is still recommended

@dcarosone
Copy link
Contributor Author

My bad, markdown all in one is still recommended

Ok then it should still be in the .vscode/extensions.json ?

@dcarosone dcarosone marked this pull request as ready for review October 26, 2023 07:48
@riccardoferretti
Copy link
Collaborator

Yup, I am fixing that shortly. I also need to figure out why it's not copying the directory in the right place. Will be done in the next couple of hours

@riccardoferretti
Copy link
Collaborator

Thanks for pointing it out, I had missed that I had removed markdown AIO from the list of extensions, I was thinking of markdown-notes when I removed that line, thinking it was still on the list although we no longer use it

@dcarosone
Copy link
Contributor Author

I also need to figure out why it's not copying the directory in the right place.

In the GHA? Wasn't that because of my typo (extra s)? With that fixed, the additional mkdir can also be removed.

@riccardoferretti riccardoferretti merged commit 4276e80 into foambubble:master Oct 26, 2023
3 checks passed
@riccardoferretti
Copy link
Collaborator

Yup the issue was around that. All fixed now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants