Exclude workspace when linking to a file #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pderaaij
force-pushed
the
bug/workspaces-preview-link
branch
from
1f46eef
to
2393a8a
Compare
|
Thanks @pderaaij - a couple of things:
|
|
Will add a test. Focussed on #1290 first. |
|
@riccardoferretti I am bit lost on the best way to add a test for this situation. The end-2-end test suite runs a single-root workspace. I can't see a way how to manipulate this on runtime. The alternative is to create an end-2-end test suite for a multi-root workspace, but that might be a bit too much. Do you have any thoughts on how to handle this? |
riccardoferretti
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1332 and #1277.
vscode.workspace.asRelativePathneeds to be told to exclude the workspace, as we already have in the resource location.