Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom output #21

Merged
merged 7 commits into from
Nov 27, 2023
Merged

Custom output #21

merged 7 commits into from
Nov 27, 2023

Conversation

SergioRibera
Copy link
Contributor

Feature:

  • Add custom output path as argument

image

Copy link
Owner

@fosskers fosskers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One small thing.

src/main.rs Outdated Show resolved Hide resolved
@fosskers
Copy link
Owner

Thanks! I'll merge this in as soon as I can. I have it scheduled.

@fosskers fosskers merged commit 4da661c into fosskers:master Nov 27, 2023
1 check passed
@fosskers
Copy link
Owner

fosskers commented Nov 27, 2023

Alright, merged! Thanks again for this. As you can see from the above, I made a few tweaks before merging.

I have a few other features planned which I'd like to do before you and I discuss the remaining ideas from your other PR. Do you mind waiting for a bit while I take care of that? I have a very busy December, so that will likely stretch into January.

@SergioRibera
Copy link
Contributor Author

Perfect, thank you very much, for me there is no problem, at the moment I will be keeping my fork of the project in the dev branch, maybe I can come up with interesting features, as soon as you can we can discuss the features to implement or whatever you like, just mention me without problem, I usually keep an eye on the github notifications.

@SergioRibera SergioRibera deleted the custom_output branch November 27, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants