Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to load KMS master key ID from the CREDSTASH_KMS_KEY_ID environment variable #292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexmbird
Copy link

This PR adds the option to declare the KMS key using an environment variable. If the environment variable is unset, the original alias/credstash default will prevail.

The main use case of this is supporting the use of multiple credstashes in a single AWS account in an configure-and-forget manner.

Bonus: my text editor has automatically stripped trailing spaces from a bunch of lines :)

Copy link
Contributor

@jason-fugue jason-fugue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think this is a good change, but it looks like the whitespace changes + another PR I merged earlier resulted in a conflict. Could you please resolve the conflict so that I can get this merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants