feat: Added Func<bool> IsMainThread to options
#1803
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -194,6 +194,11 @@ public sealed class SentryUnityOptions : SentryOptions | |||
| /// </summary> | |||
| public bool PerformanceAutoInstrumentationEnabled { get; set; } = false; | |||
|
|
|||
| /// <summary> | |||
| /// Allows to overwrite the check to determine whether the current thread is the main thread | |||
There was a problem hiding this comment.
I'm lacking an understanding of why would you need to override it. We should ask folks who need this hook to elaborate on the use case so we can expand on this summary here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a hook to the options to allow overwriting the check whether the current thread is the main thread.