-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add OptionConfiguration
to replace Runtime/BuildTime
#1888
Open
bitsandfoxes
wants to merge
24
commits into
feat/create-cli-config
Choose a base branch
from
feat/options-config
base: feat/create-cli-config
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+266
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bruno-garcia
reviewed
Nov 6, 2024
samples/unity-of-bugs/Assets/Scripts/SentryOptionConfiguration.cs
Outdated
Show resolved
Hide resolved
bitsandfoxes
force-pushed
the
feat/options-config
branch
from
November 7, 2024 11:09
83d68eb
to
3c7e7b1
Compare
…ntry-unity into feat/options-config
bitsandfoxes
changed the title
feat: Add
feat: Add Nov 15, 2024
OptionConfiguration
OptionConfiguration
to replace Runtime/BuildTime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1621
Based on the issue description: The aim is to have users no longer need to know or care about
Runtime
andBuildTime
differences. They write their code in once place, we use the same options at any time.Platform specifics can be controlled via the Unity precompile directives. We include a sample of those with the generated template:
The Runtime/BuildTime config got deprecated but will still be called last as keep backwards compatibility. I've updated the config window with a warning label.