Implement alignment package for MISRA C 2012 amdmt 3 #760
Conversation
| import cpp | ||
| import codingstandards.c.misra | ||
|
|
||
| predicate lexicallyEqualExpr(Expr a, Expr b) { |
There was a problem hiding this comment.
Take a look at the HashCons library, which implements structural equality. We have a copy in the Coding Standards library which was extended to support lambdas - it might be that we need to extend it further to capture alignment attributes.
| not isExcluded(v, AlignmentPackage::moreThanOneAlignmentSpecifierOnDeclarationQuery()) and | ||
| first = v.getAnAttribute() and | ||
| last = v.getAnAttribute() and | ||
| first != last and |
There was a problem hiding this comment.
Style recommendation:
| first != last and | |
| not first = last and |
| not exists(Attribute afterLast | | ||
| last.getLocation().isBefore(afterLast.getLocation(), _) and | ||
| v.getAnAttribute() = afterLast | ||
| ) |
There was a problem hiding this comment.
Why do we want to ensure that there are no attributes before before or after after? Is this to avoid double reporting? If so, why not require that before comes before after?
| * as there are multiple instances of that `Variable` if it is declared | ||
| * multiple times, they equal each other, and `getLocation()` on each variable | ||
| * returns every location result. This class must act on `DeclarationEntry`s to | ||
| * deliver reliable results. |
There was a problem hiding this comment.
In general, we should see a single instance of Variable for the same variable in the program, and the location of that variable should be the location of the definition(s). There are some exceptions to this: if a variable is declared in multiple link targets which are never statically linked in the program, or if a file is recompiled under a different set of assumptions, which can created - but in general those should not be considered here. I would therefore reword this paragraph for clarity. Note: it's certainly true that this class needs to consider DeclarationEntry's, though.
Description
Add new alignment rules 18-5 through 18-7
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
RULE-8-15RULE-8-16RULE-8-17Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.