JS: Added support for Array.prototype.toSpliced() ES2023 feature #17977
+440
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Napalys
force-pushed
the
napalys/toSpliced-support
branch
from
393ce1c
to
df4b596
Compare
Napalys
force-pushed
the
napalys/toSpliced-support
branch
from
545c340
to
52330e8
Compare
Napalys
force-pushed
the
napalys/toSpliced-support
branch
from
a369e86
to
6fa3ff3
Compare
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 5 out of 12 changed files in this pull request and generated 1 suggestion.
Files not reviewed (7)
- javascript/ql/lib/semmle/javascript/Arrays.qll: Language not supported
- javascript/ql/lib/semmle/javascript/Regexp.qll: Language not supported
- javascript/ql/test/library-tests/Arrays/DataFlow.expected: Language not supported
- javascript/ql/test/library-tests/Arrays/TaintFlow.expected: Language not supported
- javascript/ql/test/library-tests/RegExp/IsRegex/IsRegex.expected: Language not supported
- javascript/ql/test/library-tests/RegExp/IsRegex/IsRegex.ql: Language not supported
- javascript/ql/test/library-tests/TaintTracking/BasicTaintTracking.expected: Language not supported
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
|
change-note? And a comment about the DCA run? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for ES2023 feature,
Arrray.protype.toSpliced.The DCA run appears to be fine. The average run time remained consistent, and the meta queries did not detect any new alerts. This was expected due to the novelty of the
Arrray.protype.toSplicedfunction.