Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Make separate classes for different control flow node kinds #17996

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Java: Make separate classes for different control flow node kinds #17996

wants to merge 22 commits into from
+497 −343

Commits on Nov 12, 2024

  1. Java: IPA the CFG (WIP)

    @owen-mc
    owen-mc committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    df8ce5d View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Java: some mechanical transformations 

    Only one in Dominance required thinking.
    @yoff
    yoff committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    37a1b0b View commit details
    Browse the repository at this point in the history

  2. Java: More simple rewrites

    @yoff
    yoff committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    35f534f View commit details
    Browse the repository at this point in the history

  3. Java: one more 

    now we need to sort out range analysis
    @yoff
    yoff committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    3a7cf69 View commit details
    Browse the repository at this point in the history

  4. Java: Final rewrites to get things to compile 

    The equivalence relation needed for range analysis
is now on underlying `ExprParent`s, as `BasicBlock` is now an IPA type and ids are opaque.
    @yoff
    yoff committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a7d3fd9 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #3 from yoff/java/lightweight-IR-layer 

    Java: some mechanical transformations
    @owen-mc
    owen-mc authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    079042d View commit details
    Browse the repository at this point in the history

  6. Fix compilation errors in tests

    @owen-mc
    owen-mc committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    06ef793 View commit details
    Browse the repository at this point in the history

  7. Fix more compilation errors in tests

    @owen-mc
    owen-mc committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    634b679 View commit details
    Browse the repository at this point in the history

  8. Fix another compilation error

    @owen-mc
    owen-mc committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a023fd9 View commit details
    Browse the repository at this point in the history

  9. Update test expectations

    @owen-mc
    owen-mc committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ae12d27 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Fix switchexpr control flow error

    @owen-mc
    owen-mc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d854396 View commit details
    Browse the repository at this point in the history

  2. Java: fix UnreachabaleBasicBlock 

    Fix is taken from https://github.com/github/codeql/pull/711/files#diff-24d21bcfe63e29a6ef28151d9bd8eeaa610565c3ed7b846de1eb5fb0be661ae5
It is not clear why anotations are left out.
    @yoff
    yoff committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    88fb0d5 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #4 from yoff/java/lightweight-IR-layer 

    Java: fix UnreachabaleBasicBlock
    @owen-mc
    owen-mc authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ae3be0f View commit details
    Browse the repository at this point in the history

  4. Accept trivial test changes

    @owen-mc
    owen-mc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    bcc6523 View commit details
    Browse the repository at this point in the history

  5. Accept fixed test

    @owen-mc
    owen-mc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d7657db View commit details
    Browse the repository at this point in the history

  6. Add missing QLDocs

    @owen-mc
    owen-mc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9a69103 View commit details
    Browse the repository at this point in the history

  7. Use instanceof

    @owen-mc
    owen-mc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    3440aa3 View commit details
    Browse the repository at this point in the history

  8. Add change note

    @owen-mc
    owen-mc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    3a662f2 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Undo accidental bugfix 

    This is unrelated to the main purpose of this PR.
I have made a separate PR to do it here:
github#17988
    @owen-mc
    owen-mc committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    52f58ec View commit details
    Browse the repository at this point in the history

  2. Make separate classes for control flow node kinds 

    This puts all the logic of a particular control flow node kind into one
place and makes it easier to add new kinds.
    @owen-mc
    owen-mc committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d2348b5 View commit details
    Browse the repository at this point in the history

  3. Rearrange member predicates in ControlFlow::Node 

    Put all the ones which might need to be overrridden by subclasses
together for ease of reading.
    @owen-mc
    owen-mc committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    2ca2a4b View commit details
    Browse the repository at this point in the history

  4. Add missing QLDocs

    @owen-mc
    owen-mc committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    359ee98 View commit details
    Browse the repository at this point in the history