Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow import all database subfolders by selecting a folder #3797

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

reitowo
Copy link

@reitowo reitowo commented Nov 7, 2024

Add a palette command that allow user to select a folder and import all database subfolders.

This helps a lot when dealing with micro services that has dozens of databases and save user's time from repeatly choosing folders one by one.

image

@reitowo reitowo requested review from a team as code owners November 7, 2024 13:57
@reitowo reitowo changed the title feat: allow import all database subfolders by selecting a folder Allow import all database subfolders by selecting a folder Nov 7, 2024
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I've given it an initial review, but I haven't tried this out locally yet.

extensions/ql-vscode/CHANGELOG.md Outdated Show resolved Hide resolved
extensions/ql-vscode/package.json Outdated Show resolved Hide resolved
extensions/ql-vscode/src/databases/local-databases-ui.ts Outdated Show resolved Hide resolved
@reitowo
Copy link
Author

reitowo commented Nov 13, 2024

I seperated this logic out of original import folder function for better structure. Also optimized log output and unified names of this command for better understanding.

@reitowo
Copy link
Author

reitowo commented Nov 13, 2024

Done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants