Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metal: Ensure position invariance is captured from SPIRV-Cross #99261

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Metal: Ensure position invariance is captured from SPIRV-Cross #99261

merged 1 commit into from
Nov 15, 2024
+15 −3

Conversation

stuartcarnie
Copy link
Contributor

Closes #99029

This PR ensures that position invariance is captured from SPIRV-Cross and subsequently used as a compilation option to the Metal shader compiler.

@stuartcarnie stuartcarnie requested a review from a team as a code owner November 15, 2024 03:07
clayjohn
clayjohn approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great work tracking this down

drivers/metal/rendering_device_driver_metal.mm Show resolved Hide resolved
@clayjohn clayjohn added this to the 4.4 milestone Nov 15, 2024
@Repiteo Repiteo merged commit 68fe581 into godotengine:master Nov 15, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 15, 2024

Thanks!

@stuartcarnie stuartcarnie deleted the issue/99029 branch November 15, 2024 19:22
@stuartcarnie stuartcarnie mentioned this pull request Nov 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:rendering
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

World Triplanar broken on Mac - 4.4.dev3+
3 participants
@stuartcarnie @Repiteo @clayjohn