[#4294] --gtest_break_on_failure conflicts with EXPECT_NONFATAL_FAILURE. #4406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avrdan
force-pushed
the
bug/nonFatalFailure
branch
from
79d46cd
to
7484cc0
Compare
…t throw_on_failure. Updated googletest-throw-on-failure-test_.cc to set the throw_on_failure mode.
avrdan
force-pushed
the
bug/nonFatalFailure
branch
from
7484cc0
to
553c2d5
Compare
|
Note that you will almost certainly need to new tests for this (in addition to making sure all the existing ones pass, even disabled ones) to test all the edge cases you can, because I don't think we have tests for all of them here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the behavior so that the flags --gtest_break_on_failure and --gtest_throw_on_failure no longer throw or raise signals for non-fatal failure, thus allowing execution to continue.