Ensure Enter is correctly handled in Safari and Firefox #9945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/fc3728a47c04d11c5641f59f2b4503b2444899b5/gradio-5.5.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@fc3728a47c04d11c5641f59f2b4503b2444899b5#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/fc3728a47c04d11c5641f59f2b4503b2444899b5/gradio-client-1.7.1.tgzUse Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/fc3728a47c04d11c5641f59f2b4503b2444899b5/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
|
I'm still seeing the issue after rebuilding the frontend from this branch. Here's what I see on Firefox on Mac. After each edit, I click enter to "save" the change, but it doesn't work: Screen.Recording.2024-11-12.at.1.09.47.PM.mov |
|
Hmm still seeing the issue on Firefox @hannahblair: Screen.Recording.2024-11-13.at.9.58.14.AM.mov |
|
hmm firefox seems to be working for me; can you rebuild/run the frontend with actually regardless of the above I need to make a change again to make the tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change ensures that when Enter is pressed while editing a cell, we explicitly grab the current input value and save it to the data before closing the edit mode. I think Chrome seems to handle it automatically...
Closes: #7779
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh