-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spec text for KnownOperationType #947
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
See |
Neat. Not sure what the style in the spec is -- would it make sense to refer to this from 3.3.1 which describes this more informally ("if [the mutation root type] is not provided, the service does not support mutations")? |
The text as currently proposed will conflict with https://github.com/graphql/graphql-spec/pull/825/files#diff-607ee7e6b71821eecadde7d92451b978e8a75e23d596150950799dc5f8afa43e which is currently RFC2. Either #825 needs to be refactored to not use mutation in the examples, or this should use a separate example schema for this validation rule. May I suggest we follow the latter approach as it allows our example schema to grow over time. |
There seem to be a few references to Validation Rules, namely: https://github.com/graphql/graphql-spec/blame/main/spec/Section%202%20--%20Language.md#L1134-L1135 We could try that here for sure, in my opinion. May I suggest something => perhaps it makes sense for you to "take over" this PR, considering you will be leading the discussion at the WG and this rule was your idea to begin with. I sometimes wish GitHub had a UI for transferring ownership of PRs => I think it would be relatively easy for you to reopen a new one, and -- if you do -- I will close this one in favor of yours. |
If @benjaminjkraft takes this over (as I hope he will) he might want to adopt this suggestion, otherwise I will try to work on it. Good catch! |
Sure, I can take over the PR and add a separate schema. |
Replaced by #955. |
see: graphql/graphql-js#3592