Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update execution docs #1804

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Conversation

mandiwise
Copy link
Contributor

@mandiwise mandiwise commented Oct 30, 2024

Description

This PR contains updated execution content for the Learn docs. Key changes include:

  • Light editing and better linking throughout the Execution page
  • The format for resolver examples is standardized to other examples in the previous page updates
  • A new "Response" page that describes the data and errors keys in detail, including examples for different syntax, validation, and field error scenarios

@benjie @jorydotcom

Copy link

vercel bot commented Oct 30, 2024

@mandiwise is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great content! Excellent work! 🙌

src/pages/learn/execution.mdx Outdated Show resolved Hide resolved
src/pages/learn/execution.mdx Outdated Show resolved Hide resolved
src/pages/learn/execution.mdx Outdated Show resolved Hide resolved
src/pages/learn/execution.mdx Outdated Show resolved Hide resolved
src/pages/learn/execution.mdx Outdated Show resolved Hide resolved
src/pages/learn/response.mdx Outdated Show resolved Hide resolved
src/pages/learn/response.mdx Outdated Show resolved Hide resolved
src/pages/learn/response.mdx Outdated Show resolved Hide resolved
src/pages/learn/response.mdx Show resolved Hide resolved
src/pages/learn/response.mdx Outdated Show resolved Hide resolved
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go - excellent work 🙌

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graphql-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 6:15pm

@benjie benjie merged commit c7f80c8 into graphql:source Nov 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants