Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change package.json engines field from node 12 to 16 #286

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

lencioni
Copy link
Contributor

In #276 we replaced the jsonwebtoken package with jose, which uses syntax that does not work on node 14 or earlier. I think it might be worthwhile to make this compatibility a little more explicit in our engines field.

In #276 we replaced the
jsonwebtoken package with jose, which uses syntax that does not work on
node 14 or earlier. I think it might be worthwhile to make this
compatibility a little more explicit in our engines field.
@lencioni lencioni requested a review from trotzig June 25, 2024 20:38
@lencioni lencioni merged commit 210df3b into master Jun 28, 2024
4 checks passed
@lencioni lencioni deleted the engines branch June 28, 2024 14:23
lencioni added a commit that referenced this pull request Jul 30, 2024
We only support node 16+ now, so we can target this version and get a
nicer build. See:

- #286
- #276
lencioni added a commit that referenced this pull request Jul 30, 2024
We only support node 16+ now, so we can target this version and get a
nicer build. See:

- #286
- #276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants