Default to branch named "main" #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where we can't figure out a baseline commit in our CI scripts, we default to `origin/master`. This was the usual default branch name back in the days, but it has since changed to `origin/main`. I'm making the switch to "main" now. This is a breaking change but one that is easy to make non-breaking if you use a BASE_BRANCH=origin/master environment variable.
lencioni
approved these changes
Sep 27, 2024
9I73
reviewed
Oct 1, 2024
9I73
reviewed
Oct 1, 2024
| @@ -3,7 +3,7 @@ | |||
| # Make the whole script fail on errors | |||
| set -euo pipefail | |||
|
|
|||
| BASE_BRANCH=${BASE_BRANCH:-"origin/master"} | |||
| BASE_BRANCH=${BASE_BRANCH:-"origin/main"} | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| @@ -33,7 +33,7 @@ | |||
| "type": "User", | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where we can't figure out a baseline commit in our CI scripts, we default to
origin/master. This was the usual default branch name back in the days, but it has since changed toorigin/main. I'm making the switch to "main" now.This is a breaking change but one that is easy to make non-breaking if you use a BASE_BRANCH=origin/master environment variable.