Use informer index instead of listing service EndpointSlices directly #4409
+43
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
We had a production issue where Kubernetes spuriously returned 1 of 5 EndpointSlices to a list request during k8s control-plane maintenance, causing a partial outage for that service until we could restart consul-k8s. Arguably k8s returning an incomplete list response is the bigger issue, but this PR will help make consul-k8s more resilient to k8s control-plane instability.
How I've tested this PR
Ran unit tests, ran end-to-end test in a sandbox Kubernetes cluster.
How I expect reviewers to test this PR
Run unit and end-to-end tests
Checklist