Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: hashicorp/terraform@ec998a21bc95366269fbd196e09d3a458bba8be7 #5188

Merged
merged 1 commit into from
Jul 14, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 13, 2018

Normally we want to use tag references for our hashicorp/terraform vendoring, however we will need the DeprecationMessage support as soon as possible to provide the longest opportunity for upgrading off deprecated resources (e.g. aws_kms_secret data source) before Terraform 0.12 releases.

References:

Changes proposed in this pull request:

  • govendor fetch github.com/hashicorp/terraform/...@ec998a21bc95366269fbd196e09d3a458bba8be7

Output from acceptance testing: Handled during daily acceptance testing (although this looks fairly trivial anyways)

@bflad bflad added dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS. labels Jul 13, 2018
@bflad bflad requested review from apparentlymart and a team July 13, 2018 19:54
@ghost ghost added size/L Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Jul 13, 2018
@bflad bflad merged commit 3e71c3e into master Jul 14, 2018
@bflad bflad added this to the v1.28.0 milestone Jul 14, 2018
@bflad bflad deleted the v-terraform-resource-deprecation-sha branch July 14, 2018 16:41
@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants