Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node_meta attr to consul_catalog_entry #51

Closed
wants to merge 3 commits into from

Conversation

sl1pm4t
Copy link

@sl1pm4t sl1pm4t commented Jun 20, 2018

Add support for the node_meta attribute on consul_catalog_entry resource.
API Documentation: https://www.consul.io/api/catalog.html#nodemeta

This change also includes Acceptance Tests added for node_meta attribute:

=== RUN   TestAccConsulCatalogEntry_basic
--- PASS: TestAccConsulCatalogEntry_basic (3.69s)
=== RUN   TestAccConsulCatalogEntry_nodeMeta
--- PASS: TestAccConsulCatalogEntry_nodeMeta (7.25s)
=== RUN   TestAccConsulCatalogEntry_extremove
--- PASS: TestAccConsulCatalogEntry_extremove (3.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-consul/consul

@sl1pm4t
Copy link
Author

sl1pm4t commented Jun 20, 2018

Oops, I see this is a duplicate of #38 / #40.

@pearkes
Copy link
Contributor

pearkes commented Jun 20, 2018

@sl1pm4t Thanks for your PR! You're right this is a dupe. But also, following #46 (and #49) consul_catalog_entry will be deprecated in favor of consul_node and consul_service. We do not currently support node_meta in consul_node, so adding that there would be wonderful if you want to rework the PR with those incoming changes in mind. That would be relatively substantial change for your implementation, but the upstream APIs are the same.

We've just recently released the final 1.* series release (see CHANGELOG) prior to these changes.

@sl1pm4t
Copy link
Author

sl1pm4t commented Jul 3, 2018

Hi @pearkes - in the end I didn't need this change anyway. Thanks!

@sl1pm4t sl1pm4t closed this Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants