Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hashicorp-forge/bbolt and replace with official beta release #28916

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

raskchanky
Copy link
Contributor

@raskchanky raskchanky commented Nov 14, 2024

Description

This removes our dependence on hashicorp-forge/bbolt and replaces it with the official etcd-io/bbolt. Note that the fix in question, which we created the hashicorp-forge/bbolt for in the beginning, will be part of the 1.4.0 release, not part of the 1.3.x release that we currently use. That fix is here if people are interested. v1.4.0-beta.0 is the latest tag currently available.

I'm guessing we want to move off the beta tag once a stable tag has been cut but given the pace at which bbolt cuts releases, that might not be for awhile, and the move off of hashicorp-forge/bbolt needs to happen in the next few weeks for compliance reasons.

I ran go mod tidy and make proto because CI told me they needed to be run.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 14, 2024
Copy link

github-actions bot commented Nov 14, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Nov 14, 2024

CI Results:
All Go tests succeeded! ✅

@raskchanky raskchanky added this to the 1.19.0-rc milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant